search

rhadamanthe / host-grabber-pp

A web extension, originally designed for Firefox, to find and download media files from various hosts.
MIT License
16 stars 6 forks source link

Verify if old versions can work despite new download strategies in dictionaries #72

Closed rhadamanthe closed 4 years ago

rhadamanthe commented 4 years ago

71 has introduced a new strategy to find media to download.

It means dictionaries can use it. But will old versions of the extension be able to work with such an entry?

It should be verified. If there is a problem, something should be done so that it does not arise again in the future.

ghost commented 4 years ago

I can test this tonight (CEST) if it helps.

ghost commented 4 years ago

I installed version 0.8 and used my hosts.xml with the imagevenue css query. In the Debug-View I selected the entry. The "Search Pattern" showed up as undefined. A click on "Extract Links" on a page with two imagevenue images matching domain and path pattern showed tow "undefined" at the bottom. hostgrabberpp_debug

"Extract and Download" from the context menu on the page with on a page with two imagevenue images matching domain and path pattern did not discover any any links. No error shown.

I tested a couple of other pages with different image hosts and they all worked.

Seems fine to me.

rhadamanthe commented 4 years ago

Thank you for the test. :+1: I have also added some unit tests to prevent future regressions.