search

rhadamanthe / host-grabber-pp

A web extension, originally designed for Firefox, to find and download media files from various hosts.
MIT License
16 stars 6 forks source link

Reload dictionary flashes green even if the file doesn't exist #81

Closed aalhazred1650 closed 3 years ago

aalhazred1650 commented 4 years ago

I made a new pattern in the debug window, and I wanted to try it out. I downloaded the dictionary from github, and added my new XML to it. Then I added a file:/// URL for the dictionary URL and pressed Reload Dictionary. The box flashed green, so I assumed it worked. If I open the debug window again, my new entry is not in the dropdown list.

Turns out, if I put a non-existent file in the URL box, it still flashes green!

How can I use a local dictionary file?

(Firefox 80.0.1, HG++ 0.11, on Windows 10)

rhadamanthe commented 4 years ago

Hi,

You cannot use a local dictionary. Please, see this comment for an explanation. The available options for the moment are listed in the same thread, right above.

aalhazred1650 commented 4 years ago

OK, I can understand the security issue. I'll try with a local webserver instead.

What are the green flashes for then? This part of the user interface is not very clear... (e.g. what does Save Dictionary URL do?)

rhadamanthe commented 4 years ago

It means the URL is valid and that it was saved. I could add a verification to prevent file schemes to be used. The background will thus be red.

rhadamanthe commented 3 years ago

Done. It will now flash it red if the dictionary URL starts with file:/. I also fixed a bug when restauring the default URL.