search

rhaiscript / rhai

Rhai - An embedded scripting language for Rust.
https://crates.io/crates/rhai
Apache License 2.0
3.77k stars 178 forks source link

Added alias to ThinVec with internals feature #829

Closed h7kanna closed 8 months ago

h7kanna commented 8 months ago

Added alias to avoid importing thinvec separately as Expr::InterpolatedString accepts ThinVec now.

schungx commented 8 months ago

It would be better to take after StaticVec where the type is re-exported no matter what, only with pub if internals is on.

Otherwise your code would fail if internals is off. Do a cargo check to confirm.

This way, we can standardize on crate::ThinVec through-out the code. There are quite a few thin_vec::ThinVec in there that you should scan through, and a few more places of use thin_vec::ThinVec.

schungx commented 8 months ago

It is probably easier that I do it, if you prefer.

h7kanna commented 8 months ago

It is probably easier that I do it, if you prefer.

Sure.

schungx commented 8 months ago

It is probably easier that I do it, if you prefer.

Sure.

Alright, I'll close this.