rhapsodyv / Marlin

Optimized firmware for RepRap 3D printers based on the Arduino platform.
http://marlinfw.org
GNU General Public License v3.0
82 stars 429 forks source link

Filament Sensor always on #15

Closed Surrealcrow closed 3 years ago

Surrealcrow commented 3 years ago

Description

Printer: Tronxy XY Pro 2, no mods, no titan extruder.

Migrated from stock firmware to Marlin, after printing some parts realized that the filament sensor is not working, physically it turns off the light when filament runs over, double checked that it is activated on screen and with gcode and it always shows as triggered.

I downloaded the code and uncommented the lines for my printer model

Steps to Reproduce

  1. Turn the sensor on

  2. remove the filament

  3. start a print

  4. starts printing

  5. Turn the sensor on

  6. execute M119 with filament

  7. M119 response filament: TRIGGERED

  8. Remove filament and execute M119

  9. M119 response filament: TRIGGERED

If i get back to the original stock firmware, the runout filament works

Will add the conf.h files when get home

Additional Information

toxic-garden commented 3 years ago

Here's a fix for that https://github.com/rhapsodyv/Marlin/compare/tronxy-full-mks-tft...toxic-garden:fix_x5sapro_filemant_runout?fbclid=IwAR3_Mm2UwDK1W1Gdugq6grKjh-KM_SUpR4uJJDnguAg2R_wvgThm0OidIMw

toxic-garden commented 3 years ago

and yes, this is a fix for the X5SA Pro, but i heavily assume that the XY Pro 2 uses the same sensor technique, so it might be easily adaptable for XY Pro 2

rhapsodyv commented 3 years ago

Fix Merged