search

rharish101 / dilbert-viewer

A simple comic viewer for Dilbert by Scott Adams
https://dilbert-viewer.herokuapp.com
GNU Affero General Public License v3.0
26 stars 0 forks source link

URL wrong for 2011-12-01 #10

Closed REOScotte closed 1 year ago

REOScotte commented 1 year ago

The URL for 2011-12-01 is wrong. I listed the correct URL in this script that I used to download all pics. Also some of the titles have leading spaces - not sure if thats coming from the wayback machine or not.

https://github.com/REOScotte/MiscPowerShell/blob/master/DownloadDilbert.ps1

rharish101 commented 1 year ago

Thanks for the report. I found out that the issue is in the archives at archive.org. The viewer uses the earliest possible archive to find the URLs, but the earliest possible archive for 2011-12-01 is wrong (but later archives for the same date are fine). I'll try to fiddle with the way I'm scraping from archive.org and close this issue when I found a satisfactory solution.

EDIT: I fixed the URL in the cache, so it should be temporarily fixed.

rharish101 commented 1 year ago

By the way, is every other URL correct? I'm assuming that you used your script to download every comic.

REOScotte commented 1 year ago

Yes, I downloaded all the others successfully and they all have unique hashes so I know they're all different. But I haven't yet looked at all of them to confirm 😁

Another thing I noticed is that some are lower resolution than most. I wonder if a newer version has higher resolution.

From: Harish Rajagopal @.> Sent: Thursday, September 28, 2023 5:46:17 AM To: rharish101/dilbert-viewer @.> Cc: Scott Crawford @.>; Author @.> Subject: Re: [rharish101/dilbert-viewer] URL wrong for 2011-12-01 (Issue #10)

By the way, is every other URL correct? I'm assuming that you used your script to download every comic.

— Reply to this email directly, view it on GitHubhttps://github.com/rharish101/dilbert-viewer/issues/10#issuecomment-1738909088, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACYKUCMU5DFGAVLP4GBURVTX4VIPTANCNFSM6AAAAAA5IL4VHY. You are receiving this because you authored the thread.Message ID: @.***>

rharish101 commented 1 year ago

I've "fixed" this by choosing the archive that is closest in date to 2018. Hopefully this leads to proper archive.org copies.