rharriso / bower-rails

Bundler-like DSL + rake tasks for Bower on Rails
MIT License
1.46k stars 128 forks source link

Allow myself to overwrite the hard coded bower_components directory #146

Closed amacneil closed 8 years ago

amacneil commented 9 years ago

What do you think of this as a temporary solution to #143 ?

I thought about making it cleaner, allowing people to specify the full path, removing the unnecessary lib/vendor options etc, but it lead down a rabbit hole that required rewriting many things.

This solves my immediate problem (wanting to store assets in vendor/assets/bower/vendor) without changing too many other things.

SergeyKishenin commented 9 years ago

Thanks! But could you, please, apply changes of https://github.com/getaroom/bower-rails/commit/023cf5d728ff10d0de159ec6e1e821859e9bc424 by @getaroom commit into current PR?

Also, we need a changelog and readme update for this feature.

SergeyKishenin commented 9 years ago

And also, please, add some specs covering this feature! Thanks!

SergeyKishenin commented 8 years ago

Closed in favor of #183