Address ruby 23 issues: uninitialized ivar + circular requires

rharriso / bower-rails

Bundler-like DSL + rake tasks for Bower on Rails

MIT License

1.46k stars 128 forks source link

Address ruby 23 issues: uninitialized ivar + circular requires #196

Closed davetron5000 closed 8 years ago

davetron5000 commented 8 years ago

This does two things:

initialize @current_group in dsl.rb so that Ruby won't complain about it not having a value before being used.
remove the circular require between bower-rails.rb and railtie.rb. My assumption is that the require of the railtie inside bower-rails.rb is more important and more intentional so I left that and removed the require of bower-rails from the railtie. Please let me know if there's a better way to address this.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 88.079% when pulling c948180fdc3d62ab3fd7dbf03ffcc111b08d17e2 on stitchfix:address-ruby-23-issues into cb7d1653cffc838dd3dfe09fcca0449f098b66ae on rharriso:master.

SergeyKishenin commented 8 years ago

Thanks!