rharriso / bower-rails

Bundler-like DSL + rake tasks for Bower on Rails
MIT License
1.46k stars 128 forks source link

Put url parameters outside of erb on paths resolve #202

Closed adie closed 8 years ago

adie commented 8 years ago

Original problem was with fontawesome, with rake bower:resolve, bower-rails was generating urls like

  src: url(<%= asset_path 'fontawesome/fonts/fontawesome-webfont.eot?v=4.4.0' %>);

And when we tried to manually compile assets from code in production - Rails was trying to fetch that exact string from assets.digest instead of just 'fontawesome/fonts/fontawesome-webfont.eot' - and we were getting AssetNotPrecompiledError Essentially this PR just changes bower-rails to generate such urls as

  src: url(<%= asset_path 'fontawesome/fonts/fontawesome-webfont.eot' %>?v=4.4.0);
coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.2%) to 90.985% when pulling 98451ad0a7996d3d4b70f1a2fe5cbc6696ee6f3d on Fuseit:fix-css-paths-with-params into 874142c259661c2b3a27da815c64c3eb7f133555 on rharriso:master.

SergeyKishenin commented 8 years ago

Thanks!