rharriso / bower-rails

Bundler-like DSL + rake tasks for Bower on Rails
MIT License
1.46k stars 128 forks source link

Questions about the "main" directive #78

Closed jmuheim closed 10 years ago

jmuheim commented 10 years ago

I want to use https://github.com/winmarkltd/BootstrapFormHelpers using bower-rails. Sadly it doesn't specify a main directive:

{
  "name": "bootstrap-formhelpers",
  "version": "2.3.0",
  "homepage": "http://bootstrapformhelpers.com",
  "authors": [
    "Vincent Lamanna <v@cakemail.com>"
  ],
  "description": "A collection of jQuery plugins for Bootstrap.",
  "dependencies": {
    "bootstrap": "3.0.0"
  }
}

How can I use it anyway?

And in your README you're stating:

The rake bower:clean task removes every file that isn't listed in the main directive, if the component specifies a main directive.

This seems a good idea, but you should also take the ignore directive into account, as e.g. for Bootstrap, all files (including Glyphicons Halflings font family, etc.) are removed, but they are still needed.

SergeyKishenin commented 10 years ago

You are welcome to provide a PR considering ignore directive.

cc @paulnsorensen

paulnsorensen commented 10 years ago

@jmuheim if there isn't a main directive, it doesn't remove anything: https://github.com/42dev/bower-rails/blob/master/lib/tasks/bower.rake#L211

...but I'm sure you figured that out 2 months ago. I need to fix my github notifications.

jmuheim commented 10 years ago

:+1: :wink: