search

rharter / auto-value-gson

AutoValue Extension to add Gson De/Serializer support
Apache License 2.0
607 stars 103 forks source link

Respect FieldNamingStrategy when set on GsonBuilder #124

Closed 3flex closed 6 years ago

3flex commented 7 years ago

Closes #18.

The code generated by the createFieldNamingMethods() method is taken from the Gson project, so not sure how to attribute this to them; it was derived from their code but is now generated with JavaPoet. I left their license header on FieldNamingTest.java because that only has slight modifications from the code taken from their project.

This will require projects using auto-value-gson to have a runtime dependency on Gson 2.8.4+ going forward.

3flex commented 7 years ago

Added notes to correct a couple of minor issues I just noticed. I'll fix them when incorporating any feedback people have.

3flex commented 6 years ago

Finally getting around to finishing this off. I haven't pushed my changes yet, but I've rebased on master and also I've addressed the feedback with the exception of a couple of things that I've mentioned in replies to the original review feedback. Once those are fixed up I'll push a new update for review.

3flex commented 6 years ago

Updated with feedback taken into account; let me know if there's anything further that needs addressing.

3flex commented 6 years ago

@rharter just noticed you released a new version a few days ago without merging this PR - any feedback you'd like me to address?

3flex commented 6 years ago

@rharter sorry to bother you - just wondering if you have further thoughts or feedback on this PR? If I have to rebase again I probably wouldn't go through the trouble, so if you think there's value here it'd be best to merge before other changes go in.

If not feel free to close, cheers.

rharter commented 6 years ago

Sorry for letting this drop off my radar, @3flex. Thanks for the contribution!