search

rharter / auto-value-gson

AutoValue Extension to add Gson De/Serializer support
Apache License 2.0
607 stars 103 forks source link

Refactor code that was using Java 8 features #175

Closed jakekdodd closed 6 years ago

jakekdodd commented 6 years ago

Broken in #157

(sorry for the couple of automatic whitespace changes...I can resubmit without those if you wish)

JakeWharton commented 6 years ago

Why? AutoValue's processor requires Java 8 so this isn't going to prevent the requirement to use JDK 8 in your builds.

jakekdodd commented 6 years ago

@JakeWharton #157. I didn't read through the whole conversation but you're welcome to do so.

The build on master is failing (regardless of whether you build with JDK 7 or 8—I haven't touched 7 in years) and the fix only took a minute, so I did it. Since AutoValue's processor requires JDK 8 anyways, we should probably just revert the commit(s) that busted the build

NightlyNexus commented 6 years ago

isn't this change the culprit? https://github.com/rharter/auto-value-gson/pull/145 why did the build for it succeed?

jakekdodd commented 6 years ago

@NightlyNexus the CI build happened last August when that PR was first submitted, which was before the Java 8 source was merged

NightlyNexus commented 6 years ago

ahaha. good eye. perhaps Ryan would accept a PR to revert that.