search

rharter / auto-value-gson

AutoValue Extension to add Gson De/Serializer support
Apache License 2.0
603 stars 103 forks source link

Add @RunWith annotations to JUnit tests #216

Closed cushon closed 5 years ago

ZacSweers commented 5 years ago

Thanks! Out of curiosity - what spurred this? I've always wondered if it was necessary given you could run tests without them too

cushon commented 5 years ago

Thanks! Out of curiosity - what spurred this? I've always wondered if it was necessary given you could run tests without them too

As I understand it it's optional with the standard testrunners but still a good practice. We have a custom testrunner that is pickier about the annotations.

ZacSweers commented 5 years ago

👍

On Fri, Apr 26, 2019 at 11:48 AM Liam Miller-Cushon < notifications@github.com> wrote:

Thanks! Out of curiosity - what spurred this? I've always wondered if it was necessary given you could run tests without them too

As I understand it it's optional with the standard testrunners but still a good practice. We have a custom testrunner that is pickier about the annotations.

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/rharter/auto-value-gson/pull/216#issuecomment-487162843, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKMJPUV5BYLGOVUXLSQ6RTPSNFABANCNFSM4HIZDMSA .