search

rharwo / pe

0 stars 0 forks source link

Unable to use "/" in instructions #4

Open rharwo opened 5 days ago

rharwo commented 5 days ago

image.png If a user wants to use "/" in a step, it does not allow them to.

soc-pe-bot commented 1 day ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

Dear Tester, we would label this issue as NotInScope, and change its type to FeatureFlaw.

As per the course website, it is acceptable to disallow certain characters in inputs with proper justifications. And in our case, given how the add command has up to 5 parameters at once, allowing / in the input will make the command significantly harder to parse. The / symbol is extensively used within our parser to isolate and identify each of the 5 parameters, and hence trying to allow it within the parameters themselves would take more effort than it's worth, given that the / symbol is not very prevalent in ingredient names nor in steps for recipes.

However, this indeed could be a potential improvement in the future, and hence it should be NotInScope. Also based on the course website, such a bug should be considered FeatureFlaw and not a FunctionalityBug (see screenshot below).

image.png

Thank you for pointing this out, it is a suitable feature to implement for our application in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]

## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]