Release macOS arm64 binaries are x86_64

GiviMAD commented 10 months ago

Hello @synesthesiam, I just want to let you know that binaries provided for macOS arm64 at the release page are not built for arm64.

file -b piper
Mach-O 64-bit executable x86_64

For the context, I'm currently trying to write a JNI wrapper for piper so I can use it on a Java project, it's already working but I'm struggling with the macOS arm64 cross build on the pipeline, so I checked yours and saw the problem.

I forked the current piper CMakeLists.txt so the build is pretty similar. What I'm trying is to build with -DCMAKE_OSX_DEPLOYMENT_TARGET=11 -DCMAKE_OSX_ARCHITECTURES=arm64 but it seems to get ignored by the ExternalProject_Add function. I don't know too much about cmake, not sure how to solve this, I think I'll try to use an apple silicon runner https://github.com/actions/runner-images/issues/8439.

Best regards, and the project is amazing by the way, congratulations to the people behind it.

GiviMAD commented 10 months ago

It worked for me using the macos-13-xlarge runner.

kgantchev commented 8 months ago

It worked for me using the macos-13-xlarge runner.

Might I make a suggestion? Feel free to use FlyCI's M1 and M2 runners. Our runners are on average 2x faster and 2x cheaper than GitHub's AND we have a free tier for OSS projects (see below).

Install Instructrions

Easily replace your M1 runners:

jobs:
 ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m1
   steps:
   - name: 👀 Checkout repo
     uses: actions/checkout@v4

Or try the M2 runners:

jobs:
  ci:
-    runs-on: macos-latest
+    runs-on: flyci-macos-large-latest-m2
    steps:
      - name: 👀 Checkout repo
        uses: actions/checkout@v4

Pricing

Processor	vCPU	RAM (GB)	Storage	Label	Price on FlyCI	Price on GitHub
M1	4	7	28 GB	flyci-macos-large-latest-m1	$0.06	-
M1	8	14	28 GB	flyci-macos-xlarge-latest-m1	$0.12	$0.16
M2	4	7	28 GB	flyci-macos-large-latest-m2	$0.08	-
M2	8	14	28 GB	flyci-macos-xlarge-latest-m2	$0.16	-

500 mins/month Free for Public Repos

If your repo is public, then FlyCI offers 500 mins/month of free M1 runner usage with the flyci-macos-large-latest-m1 runner.

Best Regards, Kiril Gantchev CEO and co-founder of FlyCI

rhasspy / piper