rhasspy / rhasspy3

An open source voice assistant toolkit for many human languages
MIT License
295 stars 23 forks source link

Request: missing SDIST on Pypi or matching tag for 1.4.0 on Github, for easier Integration in Gentoo Overlay #58

Open onkelbeh opened 8 months ago

onkelbeh commented 8 months ago

Dear Mike,

I hope this message finds you well. I'm reaching out to express my appreciation for your library and also to discuss some improvements that could enhance its compatibility with Gentoo Overlay for Home Assistant.

Firstly, I am utilizing your library within my Gentoo Overlay for Home Assistant, and I hope you don't mind.

To streamline the integration process, I have a few suggestions:

1) Release File in SDIST format: In order to optimize the usage of Gentoo's mirror system and improve download statistics, it would be highly beneficial to have a release file available either on PyPI in SDIST format or as a tar.gz file on GitHub. You did this until 1.2.0. While I understand that GitHub releases are convenient, a PyPI SDIST tar.gz release would be preferable. This dual availability ensures flexibility in case of issues, as other integrations in the repository generally provide both options. 2) Tag for Version 1.4.0: I kindly request you to add a tag for version 1.4.0. This addition not only aids GitHub in generating a usable source archive but also ensures consistency between GitHub and PyPI releases. Aligning the GitHub release points with the commit used for the PyPI release facilitates a seamless experience for users and maintainers alike. 3) Comprehensive SDIST Build for PyPI: When creating an SDIST for PyPI, please ensure that all necessary files for building are included. A common oversight is missing files such as requirements.txt or README.md, which are referenced by setup.py during the compilation process. Ensuring the completeness of the SDIST will contribute to a smoother integration process for all distibutions using it.

I understand and appreciate the effort you invest in maintaining the library, and these suggestions are aimed at improving its accessibility for a wider user base. Your consideration of these enhancements would be highly valued.

Thank you for your dedication and hard work. Looking forward to continued collaboration.