Closed rhayes777 closed 7 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 80.77%. Comparing base (
d46f7a3
) to head (9ea688e
). Report is 22 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
If we don't combine priors with different ids then concise model info will have essentially no effect.
If we don't combine priors with different ids then concise model info will have essentially no effect.
The main point was to remove duplication of priors with the same id:
light_profile_list
0
centre
centre_0 UniformPrior [425], lower_limit = -0.1, upper_limit = 0.1
centre_1 UniformPrior [426], lower_limit = -0.1, upper_limit = 0.1
ell_comps
ell_comps_0 GaussianPrior [429], mean = 0.0, sigma = 0.3
ell_comps_1 GaussianPrior [430], mean = 0.0, sigma = 0.3
sigma 0.01
1
centre
centre_0 UniformPrior [425], lower_limit = -0.1, upper_limit = 0.1
centre_1 UniformPrior [426], lower_limit = -0.1, upper_limit = 0.1
ell_comps
ell_comps_0 GaussianPrior [429], mean = 0.0, sigma = 0.3
ell_comps_1 GaussianPrior [430], mean = 0.0, sigma = 0.3
sigma 0.012294934136946248
2
centre
centre_0 UniformPrior [425], lower_limit = -0.1, upper_limit = 0.1
centre_1 UniformPrior [426], lower_limit = -0.1, upper_limit = 0.1
ell_comps
ell_comps_0 GaussianPrior [429], mean = 0.0, sigma = 0.3
ell_comps_1 GaussianPrior [430], mean = 0.0, sigma = 0.3
sigma 0.01511654054318462
3
centre
centre_0 UniformPrior [425], lower_limit = -0.1, upper_limit = 0.1
centre_1 UniformPrior [426], lower_limit = -0.1, upper_limit = 0.1
ell_comps
ell_comps_0 GaussianPrior [429], mean = 0.0, sigma = 0.3
ell_comps_1 GaussianPrior [430],
Which the PR does -- all these priors with ids 425, 29, etc are condensed into one.
But we dont want priors with unique ids to be compressed as I think this is useful info to a user.
OK that's fine I can implement it that way
I think whatever we do with graph visualisation will require some thought
Done
Another attempt at concise that separates out the variables that cause branches of the model to differ