search

rhazdon / hugo-theme-hello-friend-ng

Pretty basic theme for Hugo that covers all of the essentials. All you have to do is start typing!
https://github.com/rhazdon/hugo-theme-hello-friend-ng/
Other
1.46k stars 777 forks source link

Favicons Not Showing unless Favicon Color is defined #326

Closed HacDan closed 3 years ago

HacDan commented 3 years ago

This may be intentional, but I don't think so. Either way, if you take a look inside the favicons partial https://github.com/rhazdon/hugo-theme-hello-friend-ng/blob/57bd108819c412e1099ba090a92569e530867619/layouts/partials/favicons.html#L1-L10

it does a check to see if [params.favicon.color] is set in the config. If it's not, the favicon partial isn't added to the head partial

https://github.com/rhazdon/hugo-theme-hello-friend-ng/blob/57bd108819c412e1099ba090a92569e530867619/layouts/partials/head.html#L35-L46

which of course means it doesn't end up in the final product.

If this is intentional, please go ahead and close this out.