search

rhazdon / hugo-theme-hello-friend-ng

Pretty basic theme for Hugo that covers all of the essentials. All you have to do is start typing!
https://github.com/rhazdon/hugo-theme-hello-friend-ng/
Other
1.45k stars 764 forks source link

Fix twitter and config #469

Closed dsapab closed 3 months ago

dsapab commented 3 months ago

Hello @rhazdon !

I am raising this pull request in order to address one issue and add one feature:

  1. I am adding the new X (ex Twitter) social media icon. I added it with a new name, in order to keep backwards compatibility and avoid breaking other themes.
  2. I am fixing an issue with the site configuration that was driving me crazy. I found your feature for enabling/disabling the theme button very nice. The problem is that in the sample site, the Author configuration keyword is breaking the configuration and nothing after that is being processed. That makes that all the flags (including the Theme flag) is not working. Moving this to the proper site makes the file work fine again.

I hope it helps! This PR can address/close the following issues as well:

  1. 456

  2. 465

  3. 435

Hope it helps! Thanks.

rhazdon commented 3 months ago

Hey @pablods90, thanks a lot! :)