search

rhboot / efibootmgr

efibootmgr development tree
GNU General Public License v2.0
514 stars 97 forks source link

Remove use of popt #114

Closed rossburton closed 3 years ago

rossburton commented 5 years ago

Like efivar, it would be nice if popt was replaced with getopt_long, as popt is very old and unmaintained.

rbisewski commented 5 years ago

I think I like this idea. The last major revision of popt, v1.16, was released in 2010, and mostly only very minor tweaks since it looks unmaintained; confer the Debian revision history here.

Probably gengetopt could be used to recreate the argument parser in getopt_long style. Right now in this repo, I believe the following files depend on popt:

If anyone is interested in doing this, I think smaller diffs might be good, so I think maybe there should be 3 tickets and separate PR branches for each file, so that this could be tested better.

Peter Jones, if nobody gets around to this, I could probably do it at some point :)

vathpela commented 4 years ago

In general I hate getopt and popt is much nicer, but its maintenance has certainly suffered for quite some time. I'll be happy to review some PRs.

tpgxyz commented 4 years ago

popt-1.18 has been released couple days ago, so it is not dead :) https://github.com/rpm-software-management/popt

rossburton commented 4 years ago

😮

rbisewski commented 4 years ago

I didn't think would ever happen, I figured popt was dead, but it does look like there is a new release.

Well, I suppose we could leave popt in the efibootmgr since that seems to be the crux of this issue.

Did you perhaps want to close the issue rossburton? Or did you have other concerns with popt?

rossburton commented 4 years ago

Less dependencies are good, but the primary reason for dropping popt was that it was unmaintained thus hard to get through legal approval to release. So I'm happy either way.

martinezjavier commented 3 years ago

I guess we can close this issue since popt doesn't seem to be unmaintained anymore, which was the rationale for asking the change? If someone is willing to write a patch, @vathpela said that will be happy to review it.