efivar 39 with efibootmgr 0ca99d4 fails to compile

heitbaum commented 9 months ago

https://github.com/rhboot/efivar/pull/217 hasn’t been merged in efivar-39 which was required by #162

UNPACK      efibootmgr
BUILD      efibootmgr (target)
TOOLCHAIN      make (auto-detect)
make -C src efibootmgr
make[1]: Entering directory '/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src'
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc   -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/efivar -fgnu89-inline -Wno-pointer-sign -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src/include -Werror -Wall -Wextra -Wsign-compare -Wstrict-aliasing -std=gnu11 -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale/\" -DEFIBOOTMGR_VERSION="\"18\"" -DDEFAULT_LOADER=\"\\\\EFI\\\\BOOT\\\\bootx64.efi\"     -c -o efibootmgr.o efibootmgr.c
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc   -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/efivar -fgnu89-inline -Wno-pointer-sign -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src/include -Werror -Wall -Wextra -Wsign-compare -Wstrict-aliasing -std=gnu11 -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale/\" -DEFIBOOTMGR_VERSION="\"18\"" -DDEFAULT_LOADER=\"\\\\EFI\\\\BOOT\\\\bootx64.efi\"     -c -o efi.o efi.c
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/bin/x86_64-libreelec-linux-gnu-gcc   -march=x86-64-v3 -Wall -pipe  -O2 -fomit-frame-pointer -DNDEBUG -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/efivar -fgnu89-inline -Wno-pointer-sign -I/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src/include -Werror -Wall -Wextra -Wsign-compare -Wstrict-aliasing -std=gnu11 -fPIC -D_FILE_OFFSET_BITS=64 -D_GNU_SOURCE -DLOCALEDIR=\"/usr/share/locale/\" -DEFIBOOTMGR_VERSION="\"18\"" -DDEFAULT_LOADER=\"\\\\EFI\\\\BOOT\\\\bootx64.efi\"     -c -o parse_loader_data.o parse_loader_data.c
efi.c: In function 'make_linux_load_option':
efi.c:177:26: error: implicit declaration of function 'efi_generate_ipv4_device_path_with_uri'; did you mean 'efi_generate_ipv4_device_path'? [-Werror=implicit-function-declaration]
177 |                 needed = efi_generate_ipv4_device_path_with_uri(
  |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  |                          efi_generate_ipv4_device_path
cc1: all warnings being treated as errors
make[1]: *** [/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/Make.rules:32: efi.o] Error 1
make[1]: Leaving directory '/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-12.0-devel/build/efibootmgr-0ca99d442e9d0a49d3ec373413d781ca392b57bc/src'
make: *** [Makefile:25: efibootmgr] Error 2

crossref: https://github.com/rhboot/efivar/issues/263

heitbaum commented 9 months ago

I can confirm a revert of #162 allows a successful compile against efivar-39

lupoDharkael commented 8 months ago

The CI also seems to be failing since that commit, I had to revert that commit in order to compile against efivar-39.

heitbaum commented 7 months ago

The commit has now been reverted e616023ec335b409056aea6c2b8805d82bd9668a

rhboot / efibootmgr

efivar 39 with efibootmgr 0ca99d4 fails to compile #204