search

rhboot / efibootmgr

efibootmgr development tree
GNU General Public License v2.0
514 stars 97 forks source link

Make.defaults fails to detect gcc #57

Closed floppym closed 8 years ago

floppym commented 8 years ago

efibootmgr suffers the same broken compiler detection that was fixed in https://github.com/rhinstaller/efivar/commit/50fb27698cf9f71f016aa87a7b57b5a986867410.

floppym commented 8 years ago

I should also state that looking at the value of CC to determine what compiler is in use is broken in general. I could call gcc anything (like cc, for instance), and this would fail to be detected using simple string checking.

It would be more reliable to use preprocessor macros to determine this. For example:

https://gitweb.gentoo.org/repo/gentoo.git/tree/eclass/toolchain-funcs.eclass#n576