Make default '--loader' build-time configurable.

rhboot / efibootmgr

efibootmgr development tree

GNU General Public License v2.0

519 stars 99 forks source link

Make default '--loader' build-time configurable. #65

Closed rw4s closed 7 years ago

rw4s commented 7 years ago

Each distribution uses a specific 'vendor'-directory in the 'efi' directory on the EFI System Partition to store their EFI loader. There's little use in hardcoding the value for just one in 'efibootmgr', which is displayed in --help and used as default without --loader.

Simply use make OS_VENDOR=<vendor> EFI_LOADER=<loader>.efi to get the desired value. :)

vathpela commented 7 years ago

I've pushed this, though since we already had something similar in fwupdate, I've added https://github.com/rhinstaller/efibootmgr/commit/d254fa3be4a1fb3767d50d845379580ef7a65cb6 to make it more consistent with that. Basically it's:

s/OS_VENDOR/EFIDIR/
no default value, so people won't accidentally ship it set as "redhat" any more.
the ability to set it in your local development repo with "git config --local --add efibootmgr.efidir ${your_directory_here}".

vathpela commented 7 years ago

(Er, that should be https://github.com/rhinstaller/efibootmgr/commit/ced1c5fe451080998c2db06227c8e00db2cd5961 )