Error in code efibootmgr.c

rhboot / efibootmgr

efibootmgr development tree

GNU General Public License v2.0

519 stars 99 forks source link

Error in code efibootmgr.c #79

Closed zpah closed 5 years ago

zpah commented 6 years ago

Wrong format string in: https://github.com/rhboot/efibootmgr/blob/2e018c08b92c800961ec010a6a4eeb34e8f3faa0/src/efibootmgr.c#L1620

rbisewski commented 6 years ago

For context, in the latest code, I believe the this line is currently located here. In my testing I can confirm that is broken and not printing correctly. Luckily it's an easy fix:

Replace this...

error(16, "%s", "Could not set active state for %s%04X", prefices[mode], opts.num);

... with this...

error(16, "Could not set active state for %s%04X", prefices[mode], opts.num);

This seems to work on my system. I'll create a pull request in a few minutes.

vathpela commented 5 years ago

Thanks, I've pulled your PR.