search

rhboot / efibootmgr

efibootmgr development tree
GNU General Public License v2.0
514 stars 97 forks source link

in verbose mode, don’t exit() with ec, but only warn on parse errors #80

Closed hmeine closed 5 years ago

hmeine commented 6 years ago

This allowed me to inspect EFI boot menu entries despite the problem discussed in https://github.com/rhboot/efibootmgr/issues/43#issuecomment-354663183 .

In fact, the problem stems from entries like Boot003_BbsIndex, not from the regular menu entries, whatever these _BbsIndex ones are.

hmeine commented 6 years ago

I suspect warning() to write to stderr, so I guess this is not the right fix yet, since the main output is on stdout and misses newlines. However, it looks good in the terminal, and finally I got the desired output for all regular entries.

hmeine commented 6 years ago

I just checked; warning() does not write to stderr, so my solution is better than I assumed.

superm1 commented 6 years ago

I think this looks reasonable.

superm1 commented 6 years ago

Also, please open a separate issue related to the entries that couldn't be parsed. Of course you did uncover a real issue with this, and that real issue should be fixed.

vathpela commented 5 years ago

I've pushed this, with some minor changes because it landed in my tree after 8ec3e9dedb3. Feel free to re-open if I'm somehow screwed it up ;)