search

rhboot / fwupdate

System firmware update support for UEFI machines
99 stars 47 forks source link

Fix dependency chain for a parallel make issue #106

Closed Xiami2012 closed 6 years ago

Xiami2012 commented 6 years ago

See GitHub Issue #105

superm1 commented 6 years ago

Does this fix it for you every time? I know there was also another report in #102 showing a different failure.

Xiami2012 commented 6 years ago

I had run a while true; do make clean && make -j16 || break; done for around ten minutes and no failures. (w/o patch it fails for about >50% test rounds)

But this doesn't make a deterministic evidence since it's a concurrent problem. So I put an analysis trying to prove.

Issue #102 is solved in PR #107 . All details are in commit message.

superm1 commented 6 years ago

Thanks!