search

rhboot / fwupdate

System firmware update support for UEFI machines
99 stars 47 forks source link

Add fwup_version() #111

Closed hughsie closed 6 years ago

hughsie commented 6 years ago

This is required for fwupd, which needs to care about the runtime version rather than the build-time version.

superm1 commented 6 years ago

@vathpela It looks like your CI needs to be adjusted to allow PR's from other people than branches on https://github.com/rhboot/fwupdate

From https://github.com/rhboot/efivar
   c4d4f83..9896c26  master     -> origin/master
fatal: Failed to resolve 'origin/wip/hughsie/runtime-version' as a valid revision.
superm1 commented 6 years ago

@hughsie you need to also update libfwup.abixml

hughsie commented 6 years ago

@superm1 I wasn't sure about libfwup.abixml -- it looks autogenerated. I'm also not sure what type-id is.

superm1 commented 6 years ago

@hughsie yeah it does look auto-generated. I think make abidw maybe and add that to the commit? Or if @vathpela would rather just do it once at release time that's fine too and in that case this PR looks fine to me.