search

rhboot / fwupdate

System firmware update support for UEFI machines
99 stars 47 forks source link

small fixes #45

Closed superm1 closed 8 years ago

superm1 commented 8 years ago

Ubuntu recent review reported some things with shellcheck that are harmless.

superm1 commented 8 years ago

Oh I didn't realize that RHEL was giving a different string than lsb_release. My goal with that was to avoid letting invalid values get inadvertently set in a build when they shouldn't be.

I think that is definitely one approach to go about it, but is it not possible to still try to automatically detect which directory is typically used by the system? For example on Debian/Ubuntu /etc/default/grub gets populated with GRUB_DISTRIBUTOR. You could try to detect this from a few common places and if it's not found, then set it to unknown so that the builder is forced to build it in as you did in https://github.com/vathpela/fwupdate/commit/690c778d9f0f0160989af3e79346b4e137e905b3