search

rhboot / fwupdate

System firmware update support for UEFI machines
99 stars 47 forks source link

Prepend "space" to the load option #53

Closed lcp closed 6 years ago

lcp commented 8 years ago

When using shim as the first stage loader, merely the path to fwup.efi is not enough since shim will ignore the string before the first ' '. This commit prepends ' ' to the path to make shim load fwup.efi.

Signed-off-by: Gary Lin glin@suse.com

superm1 commented 8 years ago

Is this still actually needed after https://github.com/rhinstaller/fwupdate/commit/ed9722394252eed5167dad6c2c12346785f7d61b ?

lcp commented 8 years ago

Well. It actually depends on this shim commit. https://github.com/rhinstaller/shim/commit/3322257e611e2000f79726d295bb4845bbe449e7 Unfortunately, the commit changed the behavior of shim. For shim <= 0.9, a leading "space" is necessary. However, after the commit, a leading "space" breaks the boot option. A better solution is to make a new release of shim so that the packager of fwupdate can make shim >= 0.10 a hard requirement to avoid the incompatible boot option.

vathpela commented 6 years ago

So... I'm still confused about this. I'm not seeing that we actually need it currently. Am I just reading it all wrong?

lcp commented 6 years ago

This PR can be closed.