search

rhboot / shim-review

Reviews of shim
67 stars 129 forks source link

[Process Question] Ability to tag submissions as peer / submitter reviewed? #218

Open pnardini opened 2 years ago

pnardini commented 2 years ago

As I was looking through the submissions list I realized that there's no obvious (at least to me) way to quickly see which submissions have been / are in the process of being peer reviewed by other submitters. Lacking this level of visibility probably makes it difficult for:

  1. Other submitters to see which review they could pick up next to help the overall queue
  2. Approvers to quickly see the list of submissions that have been peer reviewed and just need a final look / approval

Does it make sense to define some new process bits to help with this, maybe start with a couple of tags that submitters can apply to a submission to indicate its review state? I had the following in mind:

Curious to hear others' thoughts, but also please feel free to close this issue out and point to something that already exists if I just don't know about it :)

frozencemetery commented 2 years ago

Github has tagging ("labels") and we've tried to use that, but unfortunately issue tagging is only open to project members. I think what you're asking for makes sense and other ideas are welcome. I suspect that the best solution will be to reduce the queue, though :)

pnardini commented 2 years ago

Ah, I suppose my suggestion relied on being able to restrict label application based on user name. It seems anyone with "Triage" access can apply any and all labels: https://docs.github.com/en/issues/using-labels-and-milestones-to-track-work/managing-labels, which means that applying the "Accepted" label would become possible for submitters.

Would project boards be an option? Seems like a promising new way to provide the workflow management we're talking about: https://docs.github.com/en/issues/organizing-your-work-with-project-boards

Reducing the queue would be the best (and ultimate) solution for sure. Is there anything else that can be done by submitters to help with this outside of the peer reviews being done and what's being suggested here?