rhboot / shim-review

Reviews of shim
66 stars 130 forks source link

Shim 15.8 for AlmaLinux OS 8 (aarch64) #432

Closed eabdullin1 closed 4 months ago

eabdullin1 commented 4 months ago

Confirm the following are included in your repo, checking each box:


What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/AlmaLinux/shim-review/tree/almalinux-8-shim-aarch64-20240718


What is the SHA256 hash of your final SHIM binary?


1b3142f0c76df4942088fda2b2e4693d3d727893db2a7aaf5eb6fcefaec51b7a  shimaa64.efi

What is the link to your previous shim review request (if any, otherwise N/A)?



If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?


steve-mcintyre commented 4 months ago

Contacts verified previously

aronowski commented 4 months ago

As good as the application for x86_64: https://github.com/rhboot/shim-review/issues/407

The binary seems alright and the checksum matches the rebuilt one (Took me 32m29.073s to rebuild due to architectural differences ;-)). One more positive review (may be from a non-accredited reviewer) and it can be accepted.

dennis-tseng99 commented 4 months ago

=== Review for Shim 15.8 Shim 15.8 for AlmaLinux OS 8 (aarch64) #432 ===

grub2: NTFS module is not included. sbat,1,SBAT Version,sbat,1,https://github.com/rhboot/shim/blob/main/SBAT.md grub,3,Free Software Foundation,grub,2.02,https//www.gnu.org/software/grub/ grub.rh,2,Red Hat,grub2,2.02-156.el8,mailto:secalert@redhat.com grub.almalinux,2,AlmaLinux,grub2,2.02-156.el8.alma.1,mail:security@almalinux.org


NTFS module is not included, but you answer "Yes" in your questionnaire:

Do you have fixes for all the following GRUB2 CVEs applied? ......... October 2023 - NTFS vulnerabilities Details: https://lists.gnu.org/archive/html/grub-devel/2023-10/msg00028.html, SBAT increase to 4 CVE-2023-4693 CVE-2023-4692



- Certificate Validity: 10 years is ok, but NIST deems RSA 2048 suffficient until 2030. hmm...
openssl x509 -in almalinux-sb-cert-3.der -inform der -noout -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            c3:8b:43:54:da:0e:40:94:87:23:0d:e7:64:25:6a:db
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: emailAddress = security@almalinux.org, O = AlmaLinux OS Foundation, CN = AlmaLinux Secure Boot CA
        Validity
            Not Before: Mar 14 01:51:13 2024 GMT
            Not After : Mar 14 01:51:13 2034 GMT
        Subject: emailAddress = security@almalinux.org, O = AlmaLinux OS Foundation, CN = AlmaLinux Secure Boot CA
        Subject Public Key Info:
            Public Key Algorithm: rsaEncryption
                RSA Public-Key: (2048 bit)
                Modulus:
                    00:b0:c0:a1:22:01:fa:bd:f1:33:f7:83:f4:76:d9:
                    eb:20:94:77:e0:a6:3d:87:b1:7a:1f:b4:53:a1:8a:
                   ...

- Conclusion:
Everything seems all right except some minor concerns. But that is ok at this stage. Let's accept it.
andrewlukoshko commented 4 months ago

@dennis-tseng99 @aronowski thank you so much for quick review.

eabdullin1 commented 4 months ago

Signed by Microsoft.

Submission ID: 13945420415662615

Closing. Thanks everyone.