rhboot / shim-review

Reviews of shim
67 stars 131 forks source link

Shim 15.8 for ZeronsoftN (patch added) #433

Open joseph-zeronsoftn opened 3 months ago

joseph-zeronsoftn commented 3 months ago

Confirm the following are included in your repo, checking each box:


What is the link to your tag in a repo cloned from rhboot/shim-review?


https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20240730


What is the SHA256 hash of your final SHIM binary?


43989d3a59ff074ec9013cc000797f2139cf9fa24b30f38fee415d4daa0a41c0  shimaa64.efi
6c0c1b656c382823c9fe37110f0bf484783aa55db380664437654020fa33150b  shimia32.efi
6d47d6e3949084b7a93c4c9332ced82ad58e985ff6431e172af12072ab3d5490  shimx64.efi

What is the link to your previous shim review request (if any, otherwise N/A)?


https://github.com/rhboot/shim-review/issues/408


If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?


no changed: https://github.com/rhboot/shim-review/issues/408

REVIEW HELPER

https://github.com/jclab-joseph/other-shim-reviews.git can help you for review.

$ git clone https://github.com/jclab-joseph/other-shim-reviews.git
$ cd other-shim-reviews
$ ./clone.sh https://github.com/zeronsoftn/shim-review/tree/zeronsoftn-shim-x86_64_ia32_aarch64-20240730
THS-on commented 3 months ago

This is currently blocked on the patches getting reviewed upstream. I'll try to ping people to have a look at it.

steve-mcintyre commented 2 months ago

@vathpela could you take a look at the patches here please?

steve-mcintyre commented 2 weeks ago

@vathpela ping?

vathpela commented 2 weeks ago

I don't have a problem with any of these patches.