Shim 15.8 for Shenxinda Security OS

lichengfxf commented 2 weeks ago

Confirm the following are included in your repo, checking each box:

[x] completed README.md file with the necessary information
[x] shim.efi to be signed
[x] public portion of your certificate(s) embedded in shim (the file passed to VENDOR_CERT_FILE)
[x] binaries, for which hashes are added to vendor_db ( if you use vendor_db and have hashes allow-listed )
[x] any extra patches to shim via your own git tree or as files
[x] any extra patches to grub via your own git tree or as files
[x] build logs
[x] a Dockerfile to reproduce the build of the provided shim EFI binaries

What is the link to your tag in a repo cloned from rhboot/shim-review?

https://github.com/lichengfxf/shim-review/tree/shim15.8-20241111 ~~https://github.com/lichengfxf/shim-review/tree/shim15.8-20241029~~

What is the SHA256 hash of your final SHIM binary?

c9b6082ecb67c2d480e9a4493a8f178b33192ffc9854a090729812bcc91a6760  shimaa64.efi
c3a1f3b87d5b3373c4027fb68044d451feff1b489f55d4666684d14f18d33dce  shimia32.efi
ed29dd29461f0dc13685eef5970ad052de4aa0515a6b6bbb0d1732d3bc7f5c80  shimx64.efi

What is the link to your previous shim review request (if any, otherwise N/A)?

N/A

If no security contacts have changed since verification, what is the link to your request, where they've been verified (if any, otherwise N/A)?

N/A

aronowski commented 5 days ago

The application is missing some bits:

the legal data entries: https://github.com/rhboot/shim-review/commit/5eef3dba327709827dcef8a295fca7d91a0c933b
in the listing of your shim SBAT entries, there's no entry like shim.shenxinda,1

Please, fix them first. Then I'll proceed with reviewing.

lichengfxf commented 4 days ago

The application is missing some bits:

the legal data entries: 5eef3db

in the listing of your shim SBAT entries, there's no entry like shim.shenxinda,1

Please, fix them first. Then I'll proceed with reviewing.

Thanks for finding these issues, I have fixed them, the corrected tag are here: https://github.com/lichengfxf/shim-review/tree/shim15.8-20241111

Thank you again for your review @aronowski

steve-mcintyre commented 3 days ago

Contact verification mails on the way

lichengfxf commented 3 days ago

Hi,

Contact verification for licheng@shenxinda.com

anchorpersons denuded heroes prescriptive handrails Paramaribo teaspoonfuls bother Crockett detractor

CG790725 commented 3 days ago

Hi,

Contact verification for chengang@shenxinda.com

renascence unmasking stagflation teaspoonful ghastliest deliberation hothouse monarchy rank imposing

steve-mcintyre commented 2 days ago

Contact verification complete

rhboot / shim-review