Improve adding sbat section example in SBAT.md

rhboot / shim

UEFI shim loader

Other

861 stars 291 forks source link

Improve adding sbat section example in SBAT.md #491

Open bernhardreiter opened 2 years ago

bernhardreiter commented 2 years ago

Add --adjust-section-vma .sbat+10000000 to the objcopy example command to make sure to add the .sbat section to the end of the binary and avoid problems like #376

vathpela commented 1 year ago

Please don't push merges into the PR, it makes it impossible to figure out what's going on.

bernhardreiter commented 1 year ago

@vathpela I usually look at the diff (which is very short for this pull-request) and had hoped that merging changes in from main would make acceptance easier. (Won't do it again in this repo.)

jsetje commented 1 year ago

@bernhardreiter I've looked at this twice now, and it seems like this is something you had to do due to something specific to your binary. I'm not sure this makes sense as a general recommendation.

bernhardreiter commented 1 year ago

@bernhardreiter I've looked at this twice now,

@jsetje thanks for having taken the time!

and it seems like this is something you had to do due to something specific to your binary. I'm not sure this makes sense as a general recommendation.

Being no expert, I do not know enough to decide this. From the descriptions in #376, it seems that I wasn't the only one with the issue and some objcopy binaries may need this option. I have suggesting it, because it seems harmless to give the option just in case someone has an objcopy binary that needs it.