search

rhboot / shim

UEFI shim loader
Other
819 stars 289 forks source link

Make the names of EFI binaries arch-independent #520

Closed dennis-tseng99 closed 1 year ago

dennis-tseng99 commented 1 year ago

Since we only build the 64-bit binaries, we don't have the issue of the mixed architecture binaries in the same directory. Besides, we will use the same install script for x86_64 and AArch64. It's easier to maintain the script with the same names.

Signed-off-by: Gary Lin glin@suse.com Signed-off-by: Dennis Tseng dennis.tseng@suse.com

julian-klode commented 1 year ago

There's plenty of folks building 32-bit ones.

dennis-tseng99 commented 1 year ago

@julian-klode Thanks for your comment. I added a compiled flag(ARCH_INDEPEND) in Makefile, shim.h, shim.c and fallback.c to let user make his/her final decision.

julian-klode commented 1 year ago

I think what we could do is try arch specific first and then the independent ones. But also I'd prefer not to have arch-independent shim binary named out there.

The moment you do it, product managers will appear and request an installer image that runs on both amd64 and arm64.😜

steve-mcintyre commented 1 year ago

I think what we could do is try arch specific first and then the independent ones. But also I'd prefer not to have arch-independent shim binary named out there.

The moment you do it, product managers will appear and request an installer image that runs on both amd64 and arm64.stuck_out_tongue_winking_eye

Agreed - this is a really bad mistake IMHO.

julian-klode commented 1 year ago

I think we're going to close this as we don't want this as there's lots of opposition here.