rhboot / shim

UEFI shim loader
Other
857 stars 292 forks source link

Drop invalid calls to `CRYPTO_set_mem_functions` #537

Closed nicholasbishop closed 1 year ago

nicholasbishop commented 1 year ago

These calls did not check the return value. If they had, it would have shown that the calls were failing due to passing NULL for the realloc function pointer. That causes an early return, so the calls weren't actually doing anything.

The malloc/realloc/free functions defined in Cryptlib/SysCall/BaseMemAllocation.c are what actually get used, so just drop the explicit call to CRYPTO_set_mem_functions.