search

rhboot / shim

UEFI shim loader
Other
819 stars 289 forks source link

Add more clear comments when decoding asn.1 tag and length bytes #564

Closed dennis-tseng99 closed 1 year ago

dennis-tseng99 commented 1 year ago

Actually, 

SpcIndirectDataContent += 2;
SpcIndirectDataContent += 3;
SpcIndirectDataContent += 4;

will skip Tag and Length fields simultaneously, rather then just skip Tag. Related comments are modified for easier tracing thereafter.

vathpela commented 1 year ago

This should be fixed in https://github.com/tianocore/edk2/blob/master/CryptoPkg/Library/BaseCryptLib/Pk/CryptAuthenticode.c , to be picked up next time we rebase, instead.