rhd-gitops-example / services

Intra-Git repository promotions for GitOps.
Apache License 2.0
7 stars 8 forks source link

Add optional parameters for specifying branches on repositories #100

Closed JustinKuli closed 4 years ago

JustinKuli commented 4 years ago

Currently we only promote from and to "master" branches. There are TODO items (see #98) to look at changing this, which I think would make sense to address at the same time.

From looking through things, I was initially confused by the newBranchName parameter that already exists - it looks like it's an undocumented optional parameter? I think it's usually just automatically generated.

That newBranchName is separate from these new parameters: it specifies the name of the new (temporary) branch pushed to the destination repository which the Pull Request can reference. The fromBranch would specify which branch in the source repository to use to create that temporary branch, and the toBranch would specify which branch in the destination repository to base the PR on.