search

rhd-gitops-example / services

Intra-Git repository promotions for GitOps.
Apache License 2.0
7 stars 8 forks source link

GitHub vs GitHub Enterprise in automerge - PR doesn't enter merged state #76

Open mnuttall opened 4 years ago

mnuttall commented 4 years ago

Further to https://github.com/rhd-gitops-example/services/pull/75/ investigate why GitHub Enterprise Pull Requests don't go into 'merged' state when a merge commit is pushed, leaving code in automerge-task.yaml of the form, 

# On GitHub Enterprise - not GitHub.com - the issue will still be open. 
# We don't know if this is a bug or a feature. One way to work around this is with code of the form, 
# export GITHUB_HOST=github.ibm.com
# hub api -XPATCH repos/mnuttall/gitops-example-dev/pulls/4 -f state=closed
# See https://github.com/github/hub/issues/1151

If unavoidable, replace the commented out section above with working code that parses the PullRequest URL to generate the hub api -XPATCH command correctly.

mnuttall commented 4 years ago

Yesterday I was contacted by the IBM GHE admin team:

Hello, Mark. I am site administrator for the IBM GitHub (https://github.ibm.com). If you don’t mind, I have a question I’d like to ask you. Your response would be very helpful. My colleagues and I have been in correspondence with GitHub Enterprise support regarding an issue that we are trying to get to the bottom of. After reviewing our logs, a repository of yours appears to have experienced the issue we’re investigating. I’d like to get your comments on experiences you might have had.

The repository in question is https://github.ibm.com/MNUTTALL/gitops-example-dev. To explain further, a portion of our userbase signs their commits. GitHub does not support merging signed commits through the GUI, so users have to manually merge their changes into master from their local machine, and then push the changes to GitHub. On pushing, the PR should automatically close. For the past few months, users have reported that their PRs are not automatically closing when they push their manually-merged changes.

Is this something that you’ve also experienced in contributing to this repository? Anything similar you’ve noticed?

Thanks so much!

mnuttall commented 4 years ago

In summary, the failure to merge the PR is a GitHub Enterprise bug that will be patched in a future update.