search

rhd-gitops-example / services

Intra-Git repository promotions for GitOps.
Apache License 2.0
7 stars 8 forks source link

Add an example how to run services as an oc plugin, fix for user.Name and user.Email #84

Closed a-roberts closed 4 years ago

a-roberts commented 4 years ago

The current state of this is: it works, but it's not the tidiest and can certainly be optimised.

By the following the example docs I've added you end up with a Docker container with oc and our services binary, with a run example, and you'll be running as an oc plugin.

I had to make additional changes here so that user.Name and user.Email were picked up correctly (suggesting we've got a bug otherwise, or this could be specific to running as a plugin).

^^ I'll test this part once I figure out where our Docker image is

@bigkevmcd @mnuttall FYI

Closes https://github.com/rhd-gitops-example/services/issues/80

Todo: working on incorporating this into the Tekton example.

a-roberts commented 4 years ago

@mnuttall I've pushed up some work as we discussed to remove the gitconfig artifact in favour of Tekton variables, I've tested the simple promote Tekton example so far and fixed some problems with the tkn command I found (it was using commitID instead of commitId, and there was a missing space)

I'm going to test remote to remote next, and then address any feedback comments

a-roberts commented 4 years ago

Remote to remote example working as well - note this relies on latest having the code in here (so, to get things working I used the image adamroberts/adam-promote:latest instead of quay.io/redhat-developer/gitops-cli - https://github.com/a-roberts/gitops-example-staging/pull/1

Ready for a good look I think!