rheinwerk-verlag / pganonymize

A commandline tool for anonymizing PostgreSQL databases
http://pganonymize.readthedocs.io/
Other
41 stars 26 forks source link

[FEATURE] Specify (SQL WHERE) search_condition, to filter the table for rows to be anonymized. #18

Closed bobslee closed 3 years ago

bobslee commented 3 years ago

@hkage please could you review my PR ? I really need to get this on PyPi. Great tool by the way! Thanks!

hkage commented 3 years ago

Thanks for your PR @bobslee This is a great idea to narrow down the data that should be anonymized. I will take a look into all open pull requests today and make a new release if everything looks ok.

hkage commented 3 years ago

Looks good to me.

bobslee commented 3 years ago

Thanks @hkage

bobslee commented 3 years ago

@hkage It seems my PR broke the docs TOC / index, see screenshot. How to fix?

image

hkage commented 3 years ago

It seems like the code snippet had broken the TOC, but I don't know exactly why. I added a sub-section for all elements before the "Provider" section (https://github.com/rheinwerk-verlag/postgresql-anonymizer/commit/b22cdfc80bf0357d0155ebdffa262a4f36dbe8e8#diff-7803db48064b8857ffa23bfa8cad7b59d218e9cc842f1b165551388118c30ac2R4) and the TOC seems to be correct.

documentation

The docs will be updated with the next release, I cannot re-upload the same version again on PyPi.

bobslee commented 3 years ago

EDIT: Nevermind, I misunderstood... noticed you already committed this.

@hkage Would you like me to create an issue to update/fix the docs (TOC) ? So it won't be forgotten.