rheinwerk-verlag / pganonymize

A commandline tool for anonymizing PostgreSQL databases
http://pganonymize.readthedocs.io/
Other
42 stars 26 forks source link

Make chunk size in the table definition dynamic #19

Closed halilkaya closed 3 years ago

halilkaya commented 3 years ago

Chunk size used while fetching data from source was hardcoded. I needed to change it according to the needs per table. This PR makes it dynamic in the schema definition.

hkage commented 3 years ago

Hi, thanks for your contribution. This looks like a nice way to overwrite the default cursor chunksize, especially for larger tables. I will take a look into the changes asap.

We should add a small explanation of the new keyword for the Sphinx documentation, too but I can do that as soon as I have merged your pull request.

hkage commented 3 years ago

Hi, could you please fix the flake8 warning before I merge your pull request?

./pganonymizer/utils.py:41:121: E501 line too long (125 > 120 characters)

I would complement the documentation afterwards. And thanks again for your work!