search

rheinwerk-verlag / pganonymize

A commandline tool for anonymizing PostgreSQL databases
http://pganonymize.readthedocs.io/
Other
42 stars 26 forks source link

Add update_json provider #52

Closed bobslee closed 8 months ago

bobslee commented 8 months ago

This provider will replace json and jsonb data values with a specified provider configuration per data type.

bobslee commented 8 months ago

@hkage Please can you check out this PR? I added tests (all succeed) and tested manually (it works). We need this feature very soon, to install from PyPi.

hkage commented 8 months ago

@bobslee Thanks for the contribution! I will take a look as soon as I can.

bobslee commented 8 months ago

Everything else looks good to me. And thanks again for your work and especially the tests and documentation.

Thanks and it was my pleasure!

hkage commented 8 months ago

I published the new release, version 0.11.0 - thanks again for your contribution.

Don't mind the failing tests - the Python 2.7 tests don't work anymore, because the Ubuntu image dropped the binary. But the tests were successful on my workstation using a pyenv environment. As we still need Python 2.7 support I will fix this issue with the test setup in a separate pull request.

bobslee commented 8 months ago

You're welcome and thank you for your quick and decent follow-up. By the way, I tested in a Python 3.8.11 env.

bobslee commented 8 months ago

@hkage When will the documentation be updated? https://pganonymize.readthedocs.io/en/latest/

hkage commented 8 months ago

I use a webhook from Read the Docs, but it seems to be broken. Maybe because GitHub changed the permissions or the key is deactivated. I will check this.

hkage commented 8 months ago

The documentation is now up to date. The project was missing the now required readthedocs.yml and the last successful documentation build was 1 year ago, so a lot has changed on the RTD side since then. Thanks for reporting.