search

rhelgeby / smprojectbase

Automatically exported from code.google.com/p/smprojectbase
0 stars 0 forks source link

Maybe rename ModuleMgr_CreateBackupCmd #36

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
According to the name I thought it actually created a backup command. The 
function's comments explain something completely different than the name 
is. Maybe change name, but at least improve the comments.

I guess it should be something like: Returns whether a backup command 
should be created or not.

Original issue reported on code.google.com by richard.helgeby@gmail.com on 26 Feb 2010 at 8:25

GoogleCodeExporter commented 9 years ago 
Yeah it is a bit misleading.  Should be more like ShouldCreateBackupCmd.

You actually just uncovered another bug too -- the base cmd doesn't require 
translations manager anymore.  So when the translations manager isn't included, 
'project_version' and 'project version' are being created.

Original comment by andrewbo...@gmail.com on 26 Feb 2010 at 11:28

GoogleCodeExporter commented 9 years ago

Original comment by andrewbo...@gmail.com on 26 Feb 2010 at 11:36