rhelgeby / smprojectbase

Automatically exported from code.google.com/p/smprojectbase
0 stars 0 forks source link

Validate result of GetFunctionByName #43

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
eventmanager.inc:EventMgr_RegisterEvent

If the function couldn't be found you're still adding it to the forward 
cache. Validate before adding.

Original issue reported on code.google.com by richard.helgeby@gmail.com on 1 Mar 2010 at 1:34

GoogleCodeExporter commented 9 years ago
Probably throw a native error if invalid, so it's easier for developers to 
debug.

Original comment by richard.helgeby@gmail.com on 1 Mar 2010 at 1:35

GoogleCodeExporter commented 9 years ago
I leave that up to the developer to not try to call functions that don't exist. 
 Since 
the end user doesn't deal with this, validation is just extra work.

Original comment by andrewbo...@gmail.com on 1 Mar 2010 at 8:57

GoogleCodeExporter commented 9 years ago
SM will throw an error when Call_Finish() tries to call a non-existant 
function.  And 
it will print the function name, that's enough information to fix it.

Original comment by andrewbo...@gmail.com on 1 Mar 2010 at 8:59

GoogleCodeExporter commented 9 years ago

Original comment by andrewbo...@gmail.com on 2 Mar 2010 at 1:34