Don't use defines for setting presets.

rhelgeby / smprojectbase

Automatically exported from code.google.com/p/smprojectbase

0 stars 0 forks source link

Don't use defines for setting presets. #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

modulemanager.inc:BaseCmd_Register

The parameter 'who' should be tagged as a enum with valid options. Then the 
values can be validated at compile time. Tagging such parameters also give a 
clue about what values that are valid.

This request applies to all other defines used this way.

Original issue reported on code.google.com by richard.helgeby@gmail.com on 16 May 2010 at 7:41

GoogleCodeExporter commented 9 years ago

Makes sense.

Original comment by andrewbo...@gmail.com on 26 Mar 2011 at 7:18

Changed state: Accepted
Added labels: ****
Removed labels: ****

GoogleCodeExporter commented 9 years ago

You did this in project-dev:24c2158e9d2c (85), so I'm closing this one for you.

Original comment by richard.helgeby@gmail.com on 27 Mar 2011 at 2:12

Changed state: Fixed
Added labels: ****
Removed labels: ****