search

rhenium2 / MyHeliumCat

MyHeliumCat - Helium hotspot utility (beacon stats, hotspot directions, etc.)
MIT License
5 stars 1 forks source link

Polly policy changes. #1

Closed ViezeVingertjes closed 2 years ago

ViezeVingertjes commented 2 years ago

Added all transient failures to the Polly policy and shortened the retry delay period.

ViezeVingertjes commented 2 years ago

I ran into a few occasions where the API would throw an ServiceUnavailable at me and the application stopped. This seems to run stable when i request a large chunk of data.

rhenium2 commented 2 years ago

Thanks for your contribution @ViezeVingertjes , this PR seems to be a very good addition. However, I believe when those transient errors happen, we should give the server some time to breathe. As a user we sure can wait couple of seconds to get our result. I'd say let's change the retry waiting coefficient to 5 or 7. Happy to merge it after that change. Thanks.