search

rhevm-qe-automation / ovirt-ansible

Ansible playbooks for ovirt management
GNU General Public License v3.0
26 stars 28 forks source link

Add journalctl log on logs collection #162

Closed mkalfon closed 6 years ago

mkalfon commented 6 years ago

This patch is needed to help track service level errors on systemd journal log.

mkalfon commented 6 years ago

@myakove please review

mkalfon commented 6 years ago

@mykaul I'm not sure I understand your question. I don't see a reference of using of ovirt-log-collector, only installing it on engine. You suggest using it instead this role? Does ovirt-log-collector also support hosts?

mykaul commented 6 years ago

@mkalfon - yes, you are duplicating the functionality of a much more capable tool. Of course it supports hosts.

StLuke commented 6 years ago

@mykaul I believe the initial thought process was to have lightweight script to gather only relevant parts of the system, this will save execution time and storage for all the QA Automation runs.

However, as this script got more and more robust it might be good to compare execution time of this role and log collector (should be easy enough as we have log-collector tests) and also storage requirements (I believe this role is still winning in this aspect). If it is withing QA requirements I would suggest to use it, as we have oVirt and Fedora maintainers for them, once we have all the functionality in sos-report and log-collector (not sure if anything required by QA is missing, if there is we might want to create an RFE).

mkalfon commented 6 years ago

@tareqalayan My fork wasn't synced. I will add additional patch for fixing having empty file in /var/tmp/*/messages.