rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

Look in the tests root dir for jira.cfg and not only in the current dir #100

Closed Horstage closed 5 years ago

Horstage commented 5 years ago

My tests are ordered like this

test
│   jira.cfg
│   conftest.py
│   ...
│
└───category1
│   │   conftest.py
│   │   ...
│
│   
└───category2
│   │   conftest.py
│   │   ...
│

When starting pytest within category1 the higher-level conftest.py is included by pytest, such that test is the actual root dir of the tests. But the jira.cfg in the root dir is ignored. This PR aims to change that!

This PR is quite conservative, I'd rather move the config to the pytest.ini, but I'll do another PR for that ;-)

codecov-io commented 5 years ago

Codecov Report

Merging #100 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #100   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files           1        1           
  Lines         222      222           
=======================================
  Hits          211      211           
  Misses         11       11
Impacted Files Coverage Δ
pytest_jira.py 95.04% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d833245...2335fcb. Read the comment docs.

Horstage commented 5 years ago

I could resolve that issue but this would go against best practices, so I won't unless you specifically ask me to.

lukas-bednar commented 5 years ago

Now tests looks much better!

I am good with this change, @petr-balogh could you please take a look at this change?

lukas-bednar commented 5 years ago

Thank you!

Horstage commented 5 years ago

I was hoping for a rather quick update of the pypi package ;-)

lukas-bednar commented 5 years ago

Please accept my apology, here you go: https://pypi.org/project/pytest-jira/