search

rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

setup_requires causes alot of problems #102

Open nilosweden opened 5 years ago

nilosweden commented 5 years ago

Kindly use the install_requires instead of setup_requires so the dependencies are handled by pip instead of easy install. This causes a lot of problem if you are behind company proxies and creates more maintenance with more configuration files.

is this something you could look into or do I need to fork this?

lukas-bednar commented 5 years ago

That change breaks pbr mechanism. I don't know, maybe it is time to migrate to something else? I might try semver, or ???

lukas-bednar commented 5 years ago

I took a look around for some other semantic versioning tools. For example autosemver also requires usage of setup_requires keyword. I am not sure how to solve this issue, I know that I don't want to give up on semantic versioning.

I am open to ideas.

nilosweden commented 5 years ago

Hi Lukas, why dont you just use the semver package and create a simple release script that bumps the version of the project based on that?

for instance: release.py --bump major/minor/patch and a version.py is generated and you import this file in your setup.py and read the version and specify this to the version in setup call?

It does not have to be more complicated than that. Also the install_requires can be filled with the content of the requirements.txt file. You simply parse the content and supply each row as a line, there are examples on internet.

Let me know if you want me to provide you with more guidance and thanks in advance for considering to move away from pbr.

lukas-bednar commented 5 years ago

I am sorry for delay, but I was off in past days. Thanks for suggestion ... would you mind to draft some PR? So we can do a review and if it works I am good with getting that in.