search

rhevm-qe-automation / pytest_jira

py.test plugin to integrate with JIRA
GNU General Public License v2.0
29 stars 25 forks source link

add retry on JSONDecodeError. fix issue #105 #106

Closed gs202 closed 5 years ago

gs202 commented 5 years ago

fix issue #105 https://github.com/rhevm-qe-automation/pytest_jira/issues/105

gs202 commented 5 years ago

JSONDecodeError class is available starting from 3.5.x. I can set the retry on any exception to support 3.4.x

lukas-bednar commented 5 years ago

Since python 3.4 has reached end of live on March of 2019, we can drop 3.4.x matrix.

gs202 commented 5 years ago

So can it be merged?

lukas-bednar commented 5 years ago

First we need to make it green. Please remove py3.4 from matrix: https://github.com/rhevm-qe-automation/pytest_jira/blob/master/tox.ini#L4 https://github.com/rhevm-qe-automation/pytest_jira/blob/master/setup.cfg#L22 https://github.com/rhevm-qe-automation/pytest_jira/blob/master/.travis.yml#L3

codecov-io commented 5 years ago

Codecov Report

Merging #106 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
+ Coverage   95.04%   95.08%   +0.04%     
==========================================
  Files           1        1              
  Lines         222      224       +2     
==========================================
+ Hits          211      213       +2     
  Misses         11       11
Impacted Files Coverage Δ
pytest_jira.py 95.08% <100%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 79cd007...4143eb9. Read the comment docs.

lukas-bednar commented 5 years ago

Thank you.